Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching in docs v0.6.2 stable does not work #689

Closed
jankrepl opened this issue May 15, 2020 · 4 comments
Closed

Searching in docs v0.6.2 stable does not work #689

jankrepl opened this issue May 15, 2020 · 4 comments
Labels

Comments

@jankrepl
Copy link

jankrepl commented May 15, 2020

In the current stable 0.6.2 docs searching just yields Searching... but never actually shows results.

Switching to dev 0.7.0.dev0 makes it work

@lucyleeow
Copy link
Contributor

Indeed. It works on the locally built docs and in the artifact from the last PR (https://1550-25860190-gh.circle-artifacts.com/0/rtd_html/index.html). Any idea @larsoner ?

@larsoner
Copy link
Contributor

Looking at the dev console when searching stable I see:

jquery.js:2 Uncaught TypeError: Search.loadIndex is not a function
    at HTMLDocument.<anonymous> (search.html?q=sphinx&check_keywords=yes&area=default:232)
    at j (jquery.js:2)
    at k (jquery.js:2)

Then some more googling:

sphinx-doc/sphinx#6244

So rebuilding should fix it. But really we could just release 0.7.0 because of animations, and maybe also once #656 is in

@lucyleeow
Copy link
Contributor

But really we could just release 0.7.0 because of animations, and maybe also once #656 is in

Sounds good, animations are big! Should I/we nag Gael about #656 or get someone else to review?

(Also master is broken with sphinx-dev build, seems to be something wrong with imports as plot_future_imports_broken.py isn't failing as it should and plot_numpy_matplotlib.py failing at import matplotlib line)

@lucyleeow
Copy link
Contributor

Fixed with new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants