Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C, C++: fundamental type parsing #9918

Conversation

jakobandersen
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Purpose

Fixes #9917 and breathe-doc/breathe#771.

Note primarily for @tk0miya: I put this in 4.3.x so it could go out immediately, and it indeed causes a crash in Breathe (because it messes with C++ internals) if users have the "wrong" order in non-type template parameters.

When multiple simple type specifiers are part of the type,
then they may appear in any order.
When multiple simple type specifiers are part of the type,
then they may appear in any order.
@tk0miya
Copy link
Member

tk0miya commented Dec 4, 2021

Okay, I'll release a new package after this PR merged.

@jakobandersen
Copy link
Contributor Author

@marxin, do you by chance have time to double check with the GCC docs that this didn't break anything? or do you have instructions for how I compile them in the current state?

@jakobandersen
Copy link
Contributor Author

Okay, I'll release a new package after this PR merged.

@tk0miya, please go ahead with a release as it fits in your schedule. I'll just rebase this if it doesn't make it in time.

@marxin
Copy link
Contributor

marxin commented Dec 5, 2021

@marxin, do you by chance have time to double check with the GCC docs that this didn't break anything? or do you have instructions for how I compile them in the current state?

Please try that yourself:

git clone https://github.com/marxin/texi2rst-generated
cd texi2rst-generated/sphinx
make html

@jakobandersen
Copy link
Contributor Author

Please try that yourself:

Thanks! No breakages found. Merging.

@jakobandersen jakobandersen merged commit 3ae124f into sphinx-doc:4.3.x Dec 5, 2021
@jakobandersen jakobandersen deleted the c-cpp-fundamental-type-permutation branch December 5, 2021 10:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants