Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9330: versionchanged causes error during pdf build #9333

Merged
merged 1 commit into from Jun 13, 2021

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Jun 13, 2021

Feature or Bugfix

  • Bugfix

Purpose

Copy link
Contributor

@jfbu jfbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits!

sphinx/domains/changeset.py Outdated Show resolved Hide resolved
sphinx/domains/changeset.py Outdated Show resolved Hide resolved
@tk0miya
Copy link
Member Author

tk0miya commented Jun 13, 2021

I noticed this should be merged into 4.0.x branch. Rebasing.

The versionchanged directive breaks doctree if its contents start with
non-paragraph element (ex. lists, tables, and so on).  It causes build
error in LaTeX.

This inserts a paragraph if the first child of the contents is not a
paragraph not to break doctree.
@tk0miya tk0miya force-pushed the 9330_versionchanged_breaks_list branch from 23a4fa0 to 7b8b3de Compare June 13, 2021 15:03
@tk0miya tk0miya changed the base branch from 4.x to 4.0.x June 13, 2021 15:03
@tk0miya tk0miya modified the milestones: 4.1.0, 4.0.3 Jun 13, 2021
@tk0miya tk0miya merged commit 7673cd6 into sphinx-doc:4.0.x Jun 13, 2021
@tk0miya tk0miya deleted the 9330_versionchanged_breaks_list branch June 13, 2021 15:37
@tk0miya
Copy link
Member Author

tk0miya commented Jun 13, 2021

Merged. Thank you for your support as always :-)

@jfbu jfbu mentioned this pull request Jun 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants