Fix #9240: Unknown node error for pending_xref_condition is raised #9246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
9240_unknown_node_pending_xref_condition
branch
4 times, most recently
from
21b1eb1
to
b7e1c8f
Compare
… raised Unknown node error for pending_xref_condition is raised if an extension that does not support the node installs a missing-reference handler.
tk0miya
force-pushed
the
9240_unknown_node_pending_xref_condition
branch
from
b7e1c8f
to
2d3d668
Compare
RuRo
reviewed
May 19, 2021
| @@ -10,6 +10,8 @@ Incompatible changes | |||
| * #9222: Update Underscore.js to 1.13.1 | |||
| * #9217: manpage: Stop creating a section directory on build manpage by default | |||
| (see :confval:`man_make_section_directory`) | |||
| * #9240: Unknown node error for pending_xref_condition is raised if an extension | |||
There was a problem hiding this comment.
@tk0miya I just noticed, that you put this in the Incompatible changes section instead of Bugs fixed. Also, this should probably read "Unknown node error for pending_xref_condition is no longer raised if ...".
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
May 19, 2021
…doc#9240) After sphinx-doc#9246, `find_pending_xref_conditions()` should be only called from intended modules. At present, the Python Domain is the only module to call it intendedly. Therefore, this removes the needless calls of the utility function from "unintended" modules.
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
May 22, 2021
…doc#9240) After sphinx-doc#9246, `find_pending_xref_conditions()` should be only called from intended modules. At present, the Python Domain is the only module to call it intendedly. Therefore, this removes the needless calls of the utility function from "unintended" modules.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
that does not support the node installs a missing-reference handler.
pending_xref_condition#9240