Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8884: Include sphinx/search/minified-js in the tarball #8886

Merged
merged 1 commit into from Feb 15, 2021

Conversation

mitya57
Copy link
Contributor

@mitya57 mitya57 commented Feb 14, 2021

In #8867 I added new JS files but unfortunately I forgot to add them to MANIFEST.in, so they are not included in distributed files on PyPI (sorry). Here I am fixing this.

@mitya57 mitya57 changed the base branch from 3.x to 3.5.x February 14, 2021 17:47
@mitya57
Copy link
Contributor Author

mitya57 commented Feb 14, 2021

Tests are failing for reasons unrelated to this PR. Maybe related to today's Pygments 2.8.0 release.

@jfbu
Copy link
Contributor

jfbu commented Feb 14, 2021

Tests are failing for reasons unrelated to this PR. Maybe related to today's Pygments 2.8.0 release.

Yes, tests are failing due to Pygments 2.8.0 and particularly its merge of pygments/pygments#1701.

@jfbu
Copy link
Contributor

jfbu commented Feb 14, 2021

our testing updated at #8887 but I prefer to wait for @tk0miya before merging it

Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tk0miya tk0miya merged commit 84f5991 into sphinx-doc:3.5.x Feb 15, 2021
@tk0miya
Copy link
Member

tk0miya commented Feb 15, 2021

Merged via #8890

tk0miya added a commit that referenced this pull request Feb 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants