test: Do test with docutils-0.17b1 #8870
Merged
+196
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
test_with_docutils0.17b1
branch
2 times, most recently
from
e6e8908 to
5012b12
Compare
tk0miya
commented
Feb 12, 2021
| if docutils.__version_info__ < (0, 17): | ||
| FIGURE_CAPTION = ".//div[@class='figure align-default']/p[@class='caption']" | ||
| else: | ||
| FIGURE_CAPTION = ".//figure/figcaption/p" |
There was a problem hiding this comment.
Since v0.17, docutils starts to use <figure> and <figcaption> for figure and its caption on HTML output.
| @@ -74,7 +74,7 @@ def test_mangle_signature(): | |||
|
|
|||
|
|
|||
| def test_extract_summary(capsys): | |||
| settings = Mock(language_code='', | |||
| settings = Mock(language_code='en', | |||
There was a problem hiding this comment.
Since v0.17, docutils starts to load language module on parsing reST document using StateMachine directly. So far, our testcase uses invalid language code for testing autosummary.
| assert_count(expected_expr, result, 1) | ||
| else: | ||
| expected_expr = """<iframe src="http://sphinx-doc.org"></iframe></section>""" | ||
| assert_count(expected_expr, result, 1) |
There was a problem hiding this comment.
Since v0.17, docutils starts to use
| expected_expr = '<p class="caption"><span class="caption-text">HIDDEN TOC</span></p>' | ||
| assert expected_expr in result | ||
| else: | ||
| expected_expr = '<p><span class="caption-text">HIDDEN TOC</span></p>' |
There was a problem hiding this comment.
As a side-effect of migration to <figcaption>, the caption of toctree is also rendered using <figcaption>, and it's broken (closing tag is missing). It would be better to use another node for toctree caption.
nschloe
pushed a commit
to live-clones/docutils
that referenced
this pull request
Feb 13, 2021
Third-party applications may (ab)use the "caption" element for other purposes as a figure caption. See sphinx-doc/sphinx#8870 git-svn-id: svn://svn.code.sf.net/p/docutils/code/trunk@8624 929543f6-e4f2-0310-98a6-ba3bd3dd1d04
jwilk
pushed a commit
to jwilk-mirrors/docutils
that referenced
this pull request
Feb 13, 2021
Third-party applications may (ab)use the "caption" element for other purposes as a figure caption. See sphinx-doc/sphinx#8870 git-svn-id: https://svn.code.sf.net/p/docutils/code/trunk/docutils@8624 929543f6-e4f2-0310-98a6-ba3bd3dd1d04
Since v0.17, docutils starts to use <figure> and <figcaption> for figure and its caption on HTML output. This modifies the expected value of our testcases to support it.
Since v0.17, docutils starts to load language module on parsing reST document using StateMachine directly. So far, our testcase uses invalid language code for testing autosummary. This fixes it to work with new docutils.
Since v0.17, docutils starts to use <section> for section on HTML output. This modifies the expected value of our testcases to support it.
Since v0.17, docutils starts to use <figcaption> for caption on HTML output. This modifies the expected value of our testcases to support it.
tk0miya
force-pushed
the
test_with_docutils0.17b1
branch
from
5012b12 to
cf2d11f
Compare
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Apr 4, 2021
Since docutils-0.17, the caption node should not use for the non-figure nodes. Therefore, this replaces it by the title node.
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Apr 4, 2021
Since docutils-0.17, the caption node should not use for the non-figure nodes. Therefore, this replaces it by the title node.
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Apr 4, 2021
Since docutils-0.17, the caption node should not use for the non-figure nodes. Therefore, this replaces it by the title node.
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Apr 4, 2021
Since docutils-0.17, the caption node should not use for the non-figure nodes. Therefore, this replaces it by the title node.
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Apr 8, 2021
Since docutils-0.17, the caption node should not use for the non-figure nodes. Therefore, this replaces it by the title node.
tk0miya
added a commit
that referenced
this pull request
Apr 8, 2021
Fix #8870: Use title node for the caption of toctree
tk0miya
added a commit
that referenced
this pull request
Apr 8, 2021
Since docutils-0.17, the caption node should not use for the non-figure nodes. Therefore, this replaces it by the title node.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix