Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astropy: Significant performance hit upgrading Sphinx 3.2.1 to 3.3.0 #8403

Closed
pllim opened this issue Nov 10, 2020 · 2 comments
Closed

astropy: Significant performance hit upgrading Sphinx 3.2.1 to 3.3.0 #8403

pllim opened this issue Nov 10, 2020 · 2 comments
Labels

Comments

@pllim
Copy link

pllim commented Nov 10, 2020

Describe the bug

Build time increased from 550-ish seconds to 1400-ish seconds when Sphinx was upgraded from 3.2.1 to 3.3.0.

To Reproduce

I am not sure how to reproduce this as the astropy package has a lot of documentation and uses its own sphinx-astropy and sphinx-automodapi on top of vanilla Sphinx.

Expected behavior

Upgrading Sphinx minor version should not have such significant slowdown.

Your project

https://github.com/astropy/astropy/ and https://readthedocs.org/projects/astropy/

Screenshots

N/A

Environment info

  • OS: Linux
  • Python version: 3.8
  • Sphinx version: 3.2.1, 3.3.0
  • Sphinx extensions: Various, see above
  • Extra tools: RTD

Additional context

Any insight would be greatly appreciated. Thank you!

@tk0miya
Copy link
Member

tk0miya commented Nov 12, 2020

I fixed some slowdown bugs in 3.3.1. Could you try the new one, please?

@pllim
Copy link
Author

pllim commented Nov 12, 2020

Yes, seems fixed. Thanks!

@pllim pllim closed this as completed Nov 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants