Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put system locale path after the paths specified by configuration #8399

Merged
merged 1 commit into from Nov 10, 2020

Conversation

mitya57
Copy link
Contributor

@mitya57 mitya57 commented Nov 9, 2020

Subject: Put system locale path after the paths specified by configuration

Feature or Bugfix

  • Bugfix

Purpose

In Debian, we ship the translation data for Sphinx in the gettext's default search path, /usr/share/locale/ (support for that was added in c0e848f). When a .mo file is present there, it takes priority over the translation files specified by the configuration, so overriding does not work. This makes the (recently added) test_customize_system_message test fail.

This amends 37235c7 and makes sure list(repo.locale_dirs) is taken into account first.

In Debian, we ship the translation data for Sphinx in the default search
path, /usr/share/locale/. When a .mo file is present there, it takes
priority over the translation files specified by the configuration, so
overriding does not work. This makes test_customize_system_message fail.
@tk0miya tk0miya added this to the 3.3.1 milestone Nov 10, 2020
@tk0miya tk0miya merged commit 52432c7 into sphinx-doc:3.3.x Nov 10, 2020
@tk0miya
Copy link
Member

tk0miya commented Nov 10, 2020

Thank you always!

tk0miya added a commit that referenced this pull request Nov 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants