Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to suppress "duplicated toc entry" warnings from epub builder #8289

Merged
merged 3 commits into from Oct 24, 2020

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Oct 5, 2020

Subject: Allow to suppress "duplicated toc entry" warnings from epub builder #8289

Feature or Bugfix

  • Feature

Purpose

I'd like to suppress this warning, while I find time to fix it

Detail

Relates

@graingert graingert force-pushed the allow-to-suppress-duplicated-toc branch from b394464 to 751f9a1 Compare October 5, 2020 08:22
graingert added a commit to graingert/sphinx that referenced this pull request Oct 5, 2020
@graingert graingert force-pushed the allow-to-suppress-duplicated-toc branch from 751f9a1 to ac70e50 Compare October 5, 2020 08:23
@graingert graingert changed the title Bump version Allow to suppress "unknown mimetype" warnings from epub builder Oct 5, 2020
graingert added a commit to graingert/sphinx that referenced this pull request Oct 5, 2020
@graingert graingert force-pushed the allow-to-suppress-duplicated-toc branch from ac70e50 to 8264c93 Compare October 5, 2020 08:26
graingert added a commit to graingert/sphinx that referenced this pull request Oct 5, 2020
@graingert graingert force-pushed the allow-to-suppress-duplicated-toc branch from 8264c93 to bd32495 Compare October 5, 2020 08:28
@graingert graingert force-pushed the allow-to-suppress-duplicated-toc branch from bd32495 to 3eecf13 Compare October 5, 2020 08:29
@graingert graingert marked this pull request as ready for review October 5, 2020 08:49
@graingert graingert changed the title Allow to suppress "unknown mimetype" warnings from epub builder Allow to suppress "duplicated toc entry" warnings from epub builder Oct 5, 2020
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

CHANGES Outdated Show resolved Hide resolved
doc/usage/configuration.rst Outdated Show resolved Hide resolved
@tk0miya tk0miya added builder:epub type:proposal a feature suggestion labels Oct 5, 2020
@tk0miya tk0miya added this to the 3.3.0 milestone Oct 5, 2020
CHANGES Outdated Show resolved Hide resolved
doc/usage/configuration.rst Outdated Show resolved Hide resolved
@graingert graingert requested a review from tk0miya October 5, 2020 21:11
CHANGES Outdated Show resolved Hide resolved
@graingert
Copy link
Contributor Author

@tk0miya suggestions applied

@graingert
Copy link
Contributor Author

@tk0miya bump

@graingert
Copy link
Contributor Author

@sphinx-doc bump

@tk0miya tk0miya merged commit 3b85187 into sphinx-doc:3.x Oct 24, 2020
@tk0miya
Copy link
Member

tk0miya commented Oct 24, 2020

Merged. Thank you for your contribution!

@graingert graingert deleted the allow-to-suppress-duplicated-toc branch October 24, 2020 11:34
@graingert
Copy link
Contributor Author

@tk0miya will this land in 3.2.2?

@tk0miya
Copy link
Member

tk0miya commented Oct 24, 2020

This will be shipped as 3.3.0.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
builder:epub type:proposal a feature suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants