Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7780: napoleon: multiple params declaration was wrongly recognized #8056

Merged
merged 2 commits into from Aug 7, 2020

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Aug 5, 2020

Feature or Bugfix

  • Bugfix

Purpose

  • refs: Render error when combining multiple input parameters in docstring #7780
  • So far, napoleon converts multiple paramaters declrarations to single
    paramaeter fields (:param: and :type:) unexpectedly. As a result,
    the output seems broken.
  • This converts it to multiple parameter fields (a pair of field for each
    parameter declration) to build parameter successfully.
  • Note: The conversion rule is available only when napoleon_use_params=True.

sphinx/ext/napoleon/docstring.py Outdated Show resolved Hide resolved
tests/test_ext_napoleon_docstring.py Outdated Show resolved Hide resolved
tests/test_ext_napoleon_docstring.py Outdated Show resolved Hide resolved
@tk0miya tk0miya force-pushed the 7780_multi_params_in_numpydoc branch 2 times, most recently from d6ef816 to 9266f02 Compare August 7, 2020 13:52
Fix a testcase that added just before sphinx-doc#8049 merged.
@tk0miya tk0miya force-pushed the 7780_multi_params_in_numpydoc branch from 9266f02 to be329d1 Compare August 7, 2020 14:46
…y recognized

So far, napoleon converts multiple paramaters declrarations to single
paramaeter fields (`:param:` and `:type:`) unexpectedly.  As a result,
the output seems broken.

This converts it to multiple parameter fields (a pair of field for each
parameter declration) to build parameter successfully.

Note: The conversion rule is available only when napoleon_use_params=True.
@tk0miya tk0miya force-pushed the 7780_multi_params_in_numpydoc branch from be329d1 to a4996f9 Compare August 7, 2020 14:47
@tk0miya tk0miya merged commit 5aa774b into sphinx-doc:3.x Aug 7, 2020
@tk0miya tk0miya deleted the 7780_multi_params_in_numpydoc branch August 7, 2020 14:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants