New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic CSS: allow more "floating" #7878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgeier Could you add a CHANGES entry please? I can't describe what is changed by this.
Note: I still don't understand what is happened now. So I'm just merging this...
I've re-based this PR and added There is no separate issue for this, one example for the problem has been reported in #7484 (comment) The problem is that it's not possible to have This PR partially reverts #7542 and #7484 to allow This is more in line with previous behavior (before #7542 and #7484). If a derived theme wants to enable This PR also adds a so-called "clearfix" (in 3098aba) to avoid elements (like images) to "flow" out of the bottom of admonitions etc. |
Thank you for the detailed explanation! Merged. |
This reverts commit 0616684. Since PR sphinx-doc/sphinx#7878 has been merged into Spinx-doc (v3.1.2), this patch is no longer needed: See sphinx-doc project, PR 7838 & 7484 with elementary patch to the basic CSS: - sphinx-doc/sphinx#7838 (comment) - sphinx-doc/sphinx#7484 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
I wasn't aware of an IMHO very un-intuitive interaction between
overflow
andfloat
: If an element has anoverflow
setting, preceding elements cannot "float" into it.That's why I'm suggesting to remove the
overflow
setting fromadmonition
andtopic
.This partially reverts my previous PR #7542. I'm only keeping the
overflow
setting onsidebar
, where "floating into it" is not desired anyway.For the other elements, it looks like we cannot have perfect "overflow" and perfect "float" behavior at the same time.
Derived themes can still add their
overflow
settings if they want.This also partially reverts my previous PR #7484. It allows "right floats" to float into
admonition
andtopic
elements (as was possible before #7484). It still doesn't allow floating into code blocks, because this would interact badly with theiroverflow
behavior (which is more important).Feature or Bugfix