Fix bug in mathjax: newest 2.x version not being loaded by latest.js #7746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in latest.js in versions 2.7.5 and below; when the current version on the CDN is 3.0 or higher, latest.js will not use the highest version of 2.x, but instead will use the version from which latest.js has been taken. See the warning section on this page: http://docs.mathjax.org/en/latest/upgrading/v2.html This PR fixes that by pointing to 2.7.7, the latest version available on the CDN.
Bump hardcoded mathjax version to 2.7.7
|
Thanks! |
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
May 30, 2020
tk0miya
added a commit
that referenced
this pull request
May 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
There is a bug in
latest.jsin versions 2.7.5 and below; when the current version on the CDN is 3.0 or higher,latest.jswill not use the highest version of 2.x, but instead will use the version from whichlatest.jshas been taken. As such, the sphinx-mathjax extension is stuck loading MathJax 2.7.5 from the CDN, whereaslatest.jsshould be loading the newest 2.x version.See the warning section on this page: http://docs.mathjax.org/en/latest/upgrading/v2.html
This PR fixes that by pointing to 2.7.7, the latest 2.X version available on the CDN.