Do not include xmlns attribute with HTML 5 doctype #7449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. Thanks, |
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Apr 9, 2020
tk0miya
added a commit
that referenced
this pull request
Apr 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: fix detection of documents generated with Sphinx by shared-mime-info
Feature or Bugfix
Purpose
<html xmlns="http://www.w3.org/1999/xhtml", shared-mime-info detects it as XHTML document, not HTML: https://gitlab.freedesktop.org/xdg/shared-mime-info/-/blob/Release-1-15/freedesktop.org.xml.in#L4000Detail
Here is how Sphinx' own documentation looks in Epiphany (GNOME browser):
Line 45 is inside a
<script>tag:Parsing fails because XHTML requires
<to be escaped as>.If I try to open
search.html, it says:error on line 27 at column 37: Specification mandates value for attribute defer.Relates