js domain: Generate node_id in the right way #7210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
commented
Feb 23, 2020
| assert (find_obj(None, None, 'NestedParentA.NestedChildA', 'class') == | ||
| ('NestedParentA.NestedChildA', ('roles', 'class'))) | ||
| ('NestedParentA.NestedChildA', | ||
| ('roles', 'nestedparenta-nestedchilda', 'class'))) |
There was a problem hiding this comment.
This is good example for new_id. It is regulated to small case and invalid characters are converted to hyphens.
tk0miya
commented
Feb 29, 2020
tk0miya
force-pushed
the
refactor_js_domain2
branch
from
f898bb1
to
ff632de
Compare
tk0miya
commented
Feb 29, 2020
|
|
||
| def note_object(self, fullname: str, objtype: str, location: Any = None) -> None: | ||
| def note_object(self, fullname: str, objtype: str, node_id: str, | ||
| location: Any = None) -> None: |
There was a problem hiding this comment.
This method takes an additional argument node_id. It would be a breaking change...
There was a problem hiding this comment.
I thought other APIs in JS domain are also changed. And I don't have good idea to keep compatibility. So I'm going with this implementation.
tk0miya
force-pushed
the
refactor_js_domain2
branch
2 times, most recently
from
07b3d34
to
21719c1
Compare
tk0miya
force-pushed
the
refactor_js_domain2
branch
from
21719c1
to
dd8088f
Compare
|
Thank you for reviewing! |
This was referenced Mar 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
funcfrom.. js:function:: func()).