You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue happens whenever there is a mismatch between the amount of arguments and the amount of type hints comments. This happens when using the (...)
Another note: type_comments is enabled by default on 2.4.0+ even if typehints is disabled. This has no effect on the final output but creates bugs such as this one on existing code
Describe the bug
Since 2.4.0, we get a failure on our test suites:
I mocked sphinx to display the stack trace:
Here's what the function looks like:
https://github.com/secdev/scapy/blob/0dd974e46b3678f02e422dacafc507f32cacde89/scapy/contrib/http2.py#L2636
The issue happens whenever there is a mismatch between the amount of arguments and the amount of type hints comments. This happens when using the
(...)
This triggers it:
This is an issue when using functions within class. You don't put a type hint for
self
(https://mypy.readthedocs.io/en/stable/cheat_sheet.html#classes)Full travis logs
https://travis-ci.com/secdev/scapy/jobs/286619573
Backup:
https://pastebin.com/raw/vxhT1cGq
To Reproduce
Steps to reproduce the behavior:
Your project
https://github.com/secdev/scapy
Environment info
Thanks for the time.
The text was updated successfully, but these errors were encountered: