Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow conversion formats to be extensible in sphinx.ext.imgconverter #6994

Closed
modelmat opened this issue Jan 6, 2020 · 4 comments
Closed
Labels
extensions type:enhancement enhance or introduce a new feature
Milestone

Comments

@modelmat
Copy link
Contributor

modelmat commented Jan 6, 2020

Is your feature request related to a problem? Please describe.
The current sphinx.ext.imgconverter extension only supports a few conversions. I would like to add more conversions, as imagemagick already supports many more.

Describe the solution you'd like
Be able to set a sphinx option and add more to the list.

Describe alternatives you've considered

  1. Creating a new extension which adds them to the list

Additional context

@modelmat modelmat added the type:enhancement enhance or introduce a new feature label Jan 6, 2020
@tk0miya tk0miya modified the milestone: 2.4.0 Jan 6, 2020
@tk0miya
Copy link
Member

tk0miya commented Jan 6, 2020

Could you post a pull request please? I think conversion rule of imagemagick is static. So no APIs are needed for this case.

@modelmat
Copy link
Contributor Author

modelmat commented Jan 6, 2020

Currently there are the three conversion formats.
If I want to add more to it (say, any other format that imagemagick supports) I have to PR to add it.

I can do this for the few formats I want, but it seems to me that it would be better if you could add extra conversion rules locally, so that there is no need to add a PR.

@tk0miya
Copy link
Member

tk0miya commented Jan 7, 2020

I consider adding APIs is very expensive approach because of conversion rule would not be changed dynamically. In addition, it would be better to add new rules imgconverter extension if useful. No reason to keep it on your local.

@modelmat
Copy link
Contributor Author

modelmat commented Jan 7, 2020

I added support for the filetype I wanted in #6998 .

@tk0miya tk0miya closed this as completed Jan 8, 2020
@tk0miya tk0miya added this to the 2.4.0 milestone Jan 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions type:enhancement enhance or introduce a new feature
Projects
None yet
Development

No branches or pull requests

2 participants