Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx.ext.graphviz: missing support for :class: option #6966

Closed
lpirl opened this issue Dec 26, 2019 · 2 comments
Closed

sphinx.ext.graphviz: missing support for :class: option #6966

lpirl opened this issue Dec 26, 2019 · 2 comments
Labels
extensions type:enhancement enhance or introduce a new feature
Milestone

Comments

@lpirl
Copy link

lpirl commented Dec 26, 2019

In Hieroglyph – a Sphinx extension to build slides/presentations – I want to apply a (CSS) class to an included dot graph.
From looking at the docs and code of sphinx.ext.graphviz, it looks as if the directives provided by sphinx.ext.graphviz don't support the :class: option.

For this specific use – but probably as well for countless extensions and tools which build on Sphinx – it would be useful if the directives provided by sphinx.ext.graphviz would support the :class: option. Especially because the :class: option belongs to the common options of the reStructuredText directives.
It would allow users to format included graphs just as images, blocks, etc.

Alternatively, one could probably wrap the included graph in a container but that is a bit cumbersome. Just imagine every element for which a class should apply would have to be wrapped in a container…

Cheers. :)

@lpirl lpirl added the type:enhancement enhance or introduce a new feature label Dec 26, 2019
tk0miya added a commit to tk0miya/sphinx that referenced this issue Dec 27, 2019
@tk0miya tk0miya added this to the 2.4.0 milestone Dec 27, 2019
tk0miya added a commit to tk0miya/sphinx that referenced this issue Dec 27, 2019
tk0miya added a commit that referenced this issue Dec 28, 2019
Close #6966: graphviz: Support ``:class:`` option
@tk0miya
Copy link
Member

tk0miya commented Dec 28, 2019

Fixed by #6967
Thank you for reporting.

@tk0miya tk0miya closed this as completed Dec 28, 2019
@lpirl
Copy link
Author

lpirl commented Dec 28, 2019

Whoop. What an unusual quick fix. :) Awesome. Cheers.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions type:enhancement enhance or introduce a new feature
Projects
None yet
Development

No branches or pull requests

2 participants