Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaTeX: refactor visit_enumerated_list() to use \sphinxsetlistlabels #6533

Merged
merged 1 commit into from
Jun 29, 2019

Conversation

jfbu
Copy link
Contributor

@jfbu jfbu commented Jun 29, 2019

Fixes: #6511

This is only refactoring. But as a result it provides way to fix #6511. As it is not yet decided if #6511 is a "bug" or not, I did not include any addition to CHANGES file.

I hesitated to ask merge to 2.1.3 as it is not clear if bugfix. But this is refactoring which is backwards compatible.

@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #6533 into 2.0 will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             2.0    #6533      +/-   ##
=========================================
- Coverage   83.7%   83.67%   -0.03%     
=========================================
  Files        266      268       +2     
  Lines      40592    40624      +32     
  Branches    5979     5982       +3     
=========================================
+ Hits       33979    33994      +15     
- Misses      5291     5305      +14     
- Partials    1322     1325       +3
Impacted Files Coverage Δ
tests/test_build_latex.py 95.33% <100%> (ø) ⬆️
sphinx/writers/latex.py 81.92% <100%> (-0.03%) ⬇️
sphinx/__init__.py 73.91% <0%> (ø)
sphinx/make_mode.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c0524...65739a4. Read the comment docs.

Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tk0miya
Copy link
Member

tk0miya commented Jun 29, 2019

Note: 2.1.x is a branch for urgent releases. So normal bugs is better to merge 2.0 branch.

@jfbu jfbu modified the milestones: 2.1.3, 2.2.0 Jun 29, 2019
@jfbu jfbu force-pushed the latex_sphinxsetlistlabels branch from 4b497a7 to 65739a4 Compare June 29, 2019 17:28
@jfbu jfbu changed the base branch from 2.1.3 to 2.0 June 29, 2019 17:28
@jfbu
Copy link
Contributor Author

jfbu commented Jun 29, 2019

Thanks for reviewing. Rebased for merge to 2.0 branch, I will merge after testing completes.

@jfbu jfbu merged commit 3eeec09 into sphinx-doc:2.0 Jun 29, 2019
jfbu added a commit that referenced this pull request Jun 29, 2019
@jfbu jfbu deleted the latex_sphinxsetlistlabels branch June 29, 2019 17:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants