Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html_logo file will be never updated #6499

Closed
tk0miya opened this issue Jun 17, 2019 · 0 comments
Closed

html_logo file will be never updated #6499

tk0miya opened this issue Jun 17, 2019 · 0 comments
Labels
builder:html type:bug
Milestone
2.2.0

Comments

@tk0miya
Copy link
Member

tk0miya commented Jun 17, 2019

Describe the bug
Once html_logo file copied, it will be never overwrited.

To Reproduce

html_logo = 'logo.jpg'

$ make html

modify logo.jpg

$ touch index.rst  # update source file to build docs again
$ make html

Expected behavior
html_logo file is updated when original file changed.

Your project
None

Screenshots
None

Environment info

  • OS: Mac
  • Python version: 3.7.3
  • Sphinx version: 2.1.1
  • Sphinx extensions: None
@tk0miya tk0miya added this to the 2.2.0 milestone Jun 17, 2019
tk0miya added a commit to tk0miya/sphinx that referenced this issue Jun 17, 2019
@tk0miya
Fix sphinx-doc#6499: html: Sphinx never updates a copy of html_logo
83c59bb
@tk0miya tk0miya mentioned this issue Jun 17, 2019
Merged
tk0miya added a commit that referenced this issue Jun 18, 2019
@tk0miya
Merge pull request #6501 from tk0miya/6499_html_logo_never_updated

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
288bf23 
Fix #6499: html: Sphinx never updates a copy of html_logo
@tk0miya tk0miya closed this as completed Jun 18, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
builder:html type:bug
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
1 participant
@tk0miya