Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3859: manpage: code-block captions are not displayed correctly #6159

Merged

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Mar 9, 2019

@tk0miya tk0miya added this to the 1.8.5 milestone Mar 9, 2019
@tk0miya tk0miya force-pushed the 3859_code-block_captions_for_manpage branch from 679a8d0 to 6fa92ff Compare March 10, 2019 02:59
@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #6159 into 1.8 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.8    #6159      +/-   ##
==========================================
+ Coverage   82.25%   82.26%   +<.01%     
==========================================
  Files         302      308       +6     
  Lines       40351    40702     +351     
  Branches     6233     6289      +56     
==========================================
+ Hits        33191    33483     +292     
- Misses       5779     5832      +53     
- Partials     1381     1387       +6
Impacted Files Coverage Δ
tests/test_build_manpage.py 100% <100%> (ø) ⬆️
sphinx/writers/manpage.py 90.62% <100%> (+0.26%) ⬆️
sphinx/make_mode.py 0% <0%> (ø)
sphinx/search/__init__.py 96.9% <0%> (ø)
sphinx/quickstart.py 0% <0%> (ø)
sphinx/errors.py 80% <0%> (ø)
sphinx/__init__.py 60% <0%> (ø)
sphinx/apidoc.py 0% <0%> (ø)
sphinx/builders/html.py 82.95% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57041a...fc99687. Read the comment docs.

@tk0miya tk0miya force-pushed the 3859_code-block_captions_for_manpage branch from 6fa92ff to f4a45c3 Compare March 10, 2019 03:22
@tk0miya tk0miya force-pushed the 3859_code-block_captions_for_manpage branch from f4a45c3 to fc99687 Compare March 10, 2019 03:41
@tk0miya tk0miya merged commit f44aa23 into sphinx-doc:1.8 Mar 10, 2019
@tk0miya tk0miya deleted the 3859_code-block_captions_for_manpage branch March 10, 2019 06:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant