Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6149: LaTeX: :index: role titles causes build error of LaTeX #6152

Merged
merged 1 commit into from Mar 10, 2019

Conversation

@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #6152 into 1.8 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.8    #6152      +/-   ##
==========================================
+ Coverage   82.25%   82.25%   +<.01%     
==========================================
  Files         308      308              
  Lines       40678    40690      +12     
  Branches     6284     6287       +3     
==========================================
+ Hits        33458    33471      +13     
  Misses       5832     5832              
+ Partials     1388     1387       -1
Impacted Files Coverage Δ
sphinx/builders/latex/__init__.py 76.82% <ø> (ø) ⬆️
tests/test_build_latex.py 95.31% <100%> (+0.02%) ⬆️
sphinx/builders/latex/transforms.py 92.46% <100%> (+0.24%) ⬆️
sphinx/builders/html.py 82.95% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f283bc...05d3e37. Read the comment docs.

Copy link
Contributor

@jfbu jfbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I only commented on a docstring. There is not too much time penalty from another transform?

sphinx/builders/latex/transforms.py Outdated Show resolved Hide resolved
@tk0miya
Copy link
Member Author

tk0miya commented Mar 9, 2019

There is not too much time penalty from another transform?

It takes 0.04-0.05 seconds for our Sphinx document. docutils' transform process is very lightweight. So no worries :-)

@jfbu
Copy link
Contributor

jfbu commented Mar 9, 2019

There is not too much time penalty from another transform?

It takes 0.04-0.05 seconds for our Sphinx document. docutils' transform process is very lightweight. So no worries :-)

good :)

Copy link
Contributor

@jfbu jfbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tk0miya
Copy link
Member Author

tk0miya commented Mar 10, 2019

Thank you always :-)

@tk0miya tk0miya merged commit f57041a into sphinx-doc:1.8 Mar 10, 2019
@tk0miya tk0miya deleted the 6149_index_on_title branch March 10, 2019 02:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants