refactor chm_htmlescape()

[tk0miya]

Feature or Bugfix

• Refactoring

Purpose

• refs: [1.8] htmlhelp: convert hex escaping to decimal escaping in .hhc/.hhk files #5853 (comment)

[tk0miya]

This is new behavior on py2. At present, it works only for .hhc file.

[tk0miya]

I just reverted this. It's too much.

[codecov]

Codecov Report

Merging #5862 into 1.8 will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              1.8    #5862      +/-   ##
==========================================
+ Coverage   82.08%   82.09%   +0.01%     
==========================================
  Files         301      307       +6     
  Lines       40160    40521     +361     
  Branches     6201     6258      +57     
==========================================
+ Hits        32964    33266     +302     
- Misses       5817     5870      +53     
- Partials     1379     1385       +6

Impacted Files	Coverage Δ
sphinx/builders/htmlhelp.py	96.42% <100%> (+0.02%)	⬆️
tests/test_build_htmlhelp.py	100% <100%> (ø)	⬆️
sphinx/make_mode.py	0% <0%> (ø)
sphinx/search/__init__.py	96.9% <0%> (ø)
sphinx/quickstart.py	0% <0%> (ø)
sphinx/errors.py	80% <0%> (ø)
sphinx/__init__.py	60% <0%> (ø)
sphinx/apidoc.py	0% <0%> (ø)
sphinx/builders/html.py	82.95% <0%> (+0.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f92aa7...6ffe549. Read the comment docs.

[ghost]

Maybe we should also change title = chm_htmlescape(title) to title = chm_htmlescape(title, True) at line 332:
https://github.com/sphinx-doc/sphinx/pull/5862/files#diff-934a4ea68760fc7303dd44a301179b73R332

Imagine someone building a .chm using Python2, and a quote " appears in title, this seems a bug in this situation.

[tk0miya]

@animalize Absolutely!

[tk0miya]

I add 2nd argument to fix the bug. see CHANGES.

[ghost]

I put this htmlhelp.py into X:\Python37\Lib\site-packages\sphinx\builders, then I can build a correct python372rc1.chm.

[tk0miya]

Thank you for reviewing! Merging now.