Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly deal with non-existing static dir in graphviz extension #5549

Merged
merged 1 commit into from Oct 28, 2018

Conversation

jdemeyer
Copy link
Contributor

Subject: if the _static destination directory does not exist, the file graphviz.css is copied to a file called _static instead of a file in the directory _static.

Feature or Bugfix

  • Bugfix

@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #5549 into 1.8 will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.8    #5549      +/-   ##
==========================================
- Coverage   82.06%   82.06%   -0.01%     
==========================================
  Files         306      300       -6     
  Lines       40366    40027     -339     
  Branches     6238     6184      -54     
==========================================
- Hits        33127    32848     -279     
+ Misses       5856     5803      -53     
+ Partials     1383     1376       -7
Impacted Files Coverage Δ
sphinx/ext/graphviz.py 31.83% <50%> (ø) ⬆️
sphinx/make_mode.py
sphinx/search/__init__.py
sphinx/quickstart.py
sphinx/errors.py
sphinx/__init__.py
sphinx/apidoc.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c584b71...d9f93f7. Read the comment docs.

@tk0miya
Copy link
Member

tk0miya commented Oct 28, 2018

Thanks!

tk0miya added a commit that referenced this pull request Oct 28, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants