Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stacklevel to warning in import_object #5471

Closed
alex opened this issue Sep 22, 2018 · 2 comments
Closed

Add stacklevel to warning in import_object #5471

alex opened this issue Sep 22, 2018 · 2 comments
Labels
api good first issue type:proposal a feature suggestion
Milestone
1.8.2

Comments

@alex
Copy link
Contributor

alex commented Sep 22, 2018

This warning: https://github.com/sphinx-doc/sphinx/blob/master/sphinx/application.py#L400-L402 doesn't have a stacklevel parameter, so you don't get clear information on where the offending call is.
@tk0miya tk0miya added type:proposal a feature suggestion api labels Sep 23, 2018
@tk0miya tk0miya added this to the 1.8.2 milestone Sep 23, 2018
@tk0miya
Copy link
Member

tk0miya commented Sep 23, 2018

+1; reasonable.

related with #5438

tk0miya added a commit to tk0miya/sphinx that referenced this issue Oct 14, 2018
@tk0miya
Fix sphinx-doc#5471: Show appropriate warning for deprecated APIs
1c6c248
@tk0miya tk0miya mentioned this issue Oct 14, 2018
Merged
tk0miya added a commit to tk0miya/sphinx that referenced this issue Oct 16, 2018
@tk0miya
Fix sphinx-doc#5471: Show appropriate warning for deprecated APIs
257394a
tk0miya added a commit that referenced this issue Oct 25, 2018
@tk0miya
Merge pull request #5532 from tk0miya/5471_better_deprecation_warnings
d0b6c52 
Fix #5471: Show appropriate warning for deprecated APIs
@tk0miya
Copy link
Member

tk0miya commented Oct 25, 2018

Fixed by #5532.
Thank you for proposal!

@tk0miya tk0miya closed this as completed Oct 25, 2018
@tk0miya tk0miya mentioned this issue Mar 2, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api good first issue type:proposal a feature suggestion
Projects
None yet
Milestone
1.8.2
Development

No branches or pull requests
2 participants
@alex @tk0miya