Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5294: sphinx-quickstart blank prompts in PowerShell #5312

Merged

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Aug 17, 2018

Feature or Bugfix

  • Bugfix

Purpose

@tk0miya tk0miya added this to the 1.7.7 milestone Aug 17, 2018
@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #5312 into 1.7 will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.7    #5312      +/-   ##
==========================================
- Coverage   82.04%   82.04%   -0.01%     
==========================================
  Files         284      284              
  Lines       37932    37935       +3     
  Branches     5880     5881       +1     
==========================================
+ Hits        31120    31122       +2     
- Misses       5498     5499       +1     
  Partials     1314     1314
Impacted Files Coverage Δ
sphinx/cmd/quickstart.py 68.28% <50%> (-0.31%) ⬇️
sphinx/builders/html.py 82.53% <0%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e623739...a22f9df. Read the comment docs.

@shimizukawa
Copy link
Member

master
image

this branch
image

@shimizukawa
Copy link
Member

default windows powershell colorschema
image

Copy link
Member

@shimizukawa shimizukawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think bold in the PowerShell is yellow, so this PR looks good to me.

@tk0miya
Copy link
Member Author

tk0miya commented Aug 19, 2018

Thanks!

@tk0miya tk0miya merged commit b50b73e into sphinx-doc:1.7 Aug 19, 2018
@tk0miya tk0miya deleted the 5294_quickstart_colorscheme_for_windows branch August 19, 2018 04:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants