Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5306: autodoc: getargspec() raises NameError for invalid typehints #5309

Merged

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Aug 17, 2018

Feature or Bugfix

  • Bugfix

Purpose

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #5309 into 1.7 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.7    #5309      +/-   ##
==========================================
- Coverage   82.05%   82.04%   -0.01%     
==========================================
  Files         284      284              
  Lines       37929    37932       +3     
  Branches     5880     5880              
==========================================
  Hits        31121    31121              
- Misses       5495     5498       +3     
  Partials     1313     1313
Impacted Files Coverage Δ
sphinx/ext/autodoc/inspector.py 8.41% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2604920...a450eb7. Read the comment docs.

@tk0miya tk0miya merged commit e623739 into sphinx-doc:1.7 Aug 17, 2018
@tk0miya tk0miya deleted the 5306_NameError_for_invalid_typehints branch August 17, 2018 13:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant