Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LaTeX: shadowrule key of sphinxsetup causes PDF build to crash since Sphinx 5.1.0 #11099

Closed
jfbu opened this issue Jan 6, 2023 · 0 comments
Closed

LaTeX: shadowrule key of sphinxsetup causes PDF build to crash since Sphinx 5.1.0 #11099

jfbu opened this issue Jan 6, 2023 · 0 comments
Labels
builder:latex type:regression
Milestone
6.1.2

Comments

@jfbu
Copy link
Contributor

jfbu commented Jan 6, 2023

Describe the bug

alas

It seems I completely botchered topic directive for PDF at #10648, although I had done what I belived to be extensive tests, but they focused on warning boxes and code-blocks. For #11096 I had forgotten to test legacy key shadowsize (replaced by div.topic_box-shadow more general key), and now I realize I also forgot to test legacy key shadowrule (which was replaced by alias div.topic_border-width).

How to Reproduce

latex_elements = {
    'sphinxsetup': 'shadowrule=5pt',
}

Environment Information

not relevant

Sphinx extensions

none

Additional context

No response
@jfbu jfbu added this to the 6.1.2 milestone Jan 6, 2023
@jfbu jfbu changed the title LaTeX: shadowrule key of sphinxsetup became undefined at Sphinx 5.1.0 LaTeX: shadowrule key of sphinxsetup causes PDF build to crash since Sphinx 5.1.0 Jan 6, 2023
jfbu added a commit to jfbu/sphinx that referenced this issue Jan 6, 2023
@jfbu
Fix sphinx-doc#11099 (shadowrule legacy sphinxsetup key vanished at 5…
7921058 
….1.0)
This was referenced Jan 6, 2023
Closed
Merged
@jfbu jfbu closed this as completed in 7945aeb Jan 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
builder:latex type:regression
Projects
None yet
Milestone
6.1.2
Development

No branches or pull requests
1 participant
@jfbu