Remove flake8 plugins in favour of Ruff #11085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieleades
changed the title
|
I'd like to remove isort as well, however with the default configuration, it will re-sort the imports. If i get time i'll mess about and see if i can't match the behaviour with a little configuration. That's a job for a different PY maybe. |
AA-Turner
reviewed
Jan 5, 2023
AA-Turner
changed the title
danieleades
commented
Jan 5, 2023
| "flake8-simplify", | ||
| "isort", | ||
| "ruff", |
There was a problem hiding this comment.
we should pin this, as ruff is moving very fast and PRs will break because of changes not related to the PRs (eg. #11086)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need both, since ruff fully replaces these plugins