Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to localStorage for search highlighting #10854

Merged
merged 2 commits into from Sep 24, 2022
Merged

Move to localStorage for search highlighting #10854

merged 2 commits into from Sep 24, 2022

Conversation

AA-Turner
Copy link
Member

Feature or Bugfix

  • Refactoring

Closes #10833

A

@AA-Turner AA-Turner added this to the 5.2.0 milestone Sep 23, 2022
@AA-Turner AA-Turner self-assigned this Sep 23, 2022
@mgeier
Copy link
Contributor

mgeier commented Sep 24, 2022

In #10833 (comment), @asmeurer said:

With my suggestion, you would still be able to manually append ?highlight= to the end of a URL.

This doesn't seem to be possible with this PR, or am I doing something wrong?

@AA-Turner
Copy link
Member Author

https://sphinx--10854.org.readthedocs.build/en/10854/usage/theming.html?highlight=navigation_with_keys#builtin-themes

@mgeier ?highlight=... support restored, with the query parameter cleared on page load.

A

@AA-Turner AA-Turner mentioned this pull request Sep 24, 2022
Closed
@AA-Turner AA-Turner merged commit e2b3b3f into sphinx-doc:5.x Sep 24, 2022
@AA-Turner AA-Turner deleted the split-highlight branch September 24, 2022 14:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@AA-Turner AA-Turner

Labels
html search
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

Clear ?highlight= query parameter from the URL
2 participants
@AA-Turner @mgeier