Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save search result score to HTML element for debugging #10718

Merged
merged 2 commits into from Sep 9, 2022
Merged

Save search result score to HTML element for debugging #10718

merged 2 commits into from Sep 9, 2022

Conversation

marxin
Copy link
Contributor

@marxin marxin commented Jul 28, 2022

It is handy for debugging of search results.

@AA-Turner AA-Turner force-pushed the search-save-priority-to-dataset branch from 800431d to 87bf1ef Compare September 9, 2022 01:53
@AA-Turner
Copy link
Member

Rebased.

A

@AA-Turner AA-Turner changed the title search: save priority to HTML element for debugging Save search resul score to HTML element for debugging Sep 9, 2022
@AA-Turner AA-Turner merged commit 454ced9 into sphinx-doc:5.x Sep 9, 2022
@AA-Turner AA-Turner changed the title Save search resul score to HTML element for debugging Save search result score to HTML element for debugging Sep 9, 2022
@marxin
Copy link
Contributor Author

marxin commented Sep 9, 2022

@AA-Turner Can you please merge the current 5.x branch into master so that I can experiment with Sphinx docs search results?

@AA-Turner
Copy link
Member

Done, but I think readthedocs's server side search is overriding searchtools.js.

If you build the docs locally you can run python -m http.server --directory build/sphinx and go to localhost:8000/ to get around CORS, does that help?

A

@marxin
Copy link
Contributor Author

marxin commented Sep 9, 2022

Great, that works fine, thanks!

@marxin marxin deleted the search-save-priority-to-dataset branch September 9, 2022 10:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marxin @AA-Turner