Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sphinx 5.1.1 release plan #10710

Closed
AA-Turner opened this issue Jul 25, 2022 · 5 comments
Closed

Sphinx 5.1.1 release plan #10710

AA-Turner opened this issue Jul 25, 2022 · 5 comments
Assignees
@AA-Turner
Labels
type:task
Milestone
5.1.1

Comments

@AA-Turner
Copy link
Member

AA-Turner commented Jul 25, 2022 •
edited

I plan to release Sphinx 5.1.1 tomorrow, Tuesday 26 July 2022 1

This release contains PR #10709 fixing issues #10701 & #10705, and PR #10702 fixing an issue with using third-party builders.

Please test the 5.1.x branch, it can be installed with pip install https://github.com/sphinx-doc/sphinx/archive/refs/heads/5.1.x.zip

With thanks in advance,
Adam

Footnotes

  1. This would be late evening British time, around 22-24 hours from now. ↩
@AA-Turner AA-Turner added this to the 5.1.1 milestone Jul 25, 2022
@AA-Turner AA-Turner self-assigned this Jul 25, 2022
This was referenced Jul 25, 2022
Closed
Closed
@adamjstewart adamjstewart mentioned this issue Jul 25, 2022
Closed
@AA-Turner AA-Turner pinned this issue Jul 25, 2022
@mwichmann
Copy link

As a "me too" on closed #10705: Works For Me.

@jdknight
Copy link
Contributor

Changes work for the use case mentioned on #10702 (both active release and development branch of the builder in question). Appreciate the merge and tweaks to the pull request.

@freakboy3742 freakboy3742 mentioned this issue Jul 26, 2022
Merged
4 tasks
@yarikoptic
Copy link

yarikoptic commented Jul 26, 2022 •
edited

Please test the 5.1.x branch, it can be installed with pip install https://github.com/sphinx-doc/sphinx/archive/refs/heads/5.1.x.zip

FWIW the version does fix #10701/#10705 for me and build completes fine (i.e. no some other regression as far as I can see).

edit: THANK YOU!

mananshah99 added a commit to pyg-team/pyg_sphinx_theme that referenced this issue Jul 26, 2022
@mananshah99
Update setup.py to sphinx >= 5.1.1
6e9681f 
NOTE: only merge after 5.1.1 is released, see sphinx-doc/sphinx#10710
@mananshah99 mananshah99 mentioned this issue Jul 26, 2022
Merged
@gpotter2 gpotter2 mentioned this issue Jul 26, 2022
Closed
@AdamGleave AdamGleave mentioned this issue Jul 26, 2022
Closed
@AA-Turner
Copy link
Member Author

I have published the release of Sphinx 5.1.1, many thanks for testing this release at such short notice, and especially to @anntzer and to @jdknight for contributing the fixes.

Adam

@anntzer
Copy link
Contributor

anntzer commented Jul 26, 2022

Sorry for the breakage I caused :)

@AA-Turner AA-Turner unpinned this issue Jul 26, 2022
mananshah99 added a commit to pyg-team/pyg_sphinx_theme that referenced this issue Jul 26, 2022
@mananshah99
Update setup.py to sphinx >= 5.1.1 (#4)
1d754bd 
See sphinx-doc/sphinx#10710
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AA-Turner AA-Turner

Labels
type:task
Projects
None yet
Milestone
5.1.1
Development

No branches or pull requests
5 participants
@yarikoptic @mwichmann @anntzer @jdknight @AA-Turner