Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with ReadTheDocs PDF rendering regarding pict2e LaTeX package #10695

Closed
jfbu opened this issue Jul 23, 2022 · 4 comments · Fixed by #10696
Closed

Problem with ReadTheDocs PDF rendering regarding pict2e LaTeX package #10695

jfbu opened this issue Jul 23, 2022 · 4 comments · Fixed by #10696
Labels
Milestone

Comments

@jfbu
Copy link
Contributor

jfbu commented Jul 23, 2022

Describe the bug

There is a problem with PDF rendering of our documentation at Read The Docs

https://readthedocs.org/projects/sphinx/builds/17516903/

How to Reproduce

visit https://www.sphinx-doc.org/en/master/ and download PDF from pop-up

Expected behavior

No response

Your project

Sphinx

Screenshots

Capture d’écran 2022-07-23 à 11 56 02

OS

?

Python version

?

Sphinx version

1199f7b

Sphinx extensions

No response

Extra tools

No response

Additional context

This looks like a problem of pict2e version being too old at Read The Docs. Surprisingly, the rounded corners are rendered correctly, the problem is with extra "pict2e" and other artefacts appearing in PDF output.

Sadly, on my current system I can not easily test older LaTeX systems, oldest I can easily check is with March 2020 TeXLive 2019. I will try to see if I can fetch older pict2e versions.

Is there a way to obtain LaTeX log from compilation at Read The Docs?

@jfbu jfbu added this to the 5.1.0 milestone Jul 23, 2022
@jfbu
Copy link
Contributor Author

jfbu commented Jul 23, 2022

Sadly, on my current system I can not easily test older LaTeX systems, oldest I can easily check is with March 2020 TeXLive 2019. I

SORRY, the problem DOES show with TeXLive 2019. I thought I had tested.

I see the nature of the problem (\@ifpackageloaded could not be used in document body but only in document preamble, which is not the case anymore with current LaTeX) so I am confident I can fix this in time for 5.1.0 release. Perhaps only after lunch (European time) or at least putting stuff in the oven.

@humitos
Copy link
Contributor

humitos commented Jul 23, 2022

Quick reply from the phone: you can use a newer Ubuntu image that will come with a newer version of that package.

You need to use "build.os: ubuntu-22.04" in your config file. Take a look at https://docs.readthedocs.io/en/stable/config-file/v2.html#build-os

Let me know if that works.

@jfbu
Copy link
Contributor Author

jfbu commented Jul 23, 2022 via email

jfbu added a commit to jfbu/sphinx that referenced this issue Jul 23, 2022
jfbu added a commit that referenced this issue Jul 23, 2022
Fix #10695: old LaTeX does not allow \@ifpackageloaded usage in body
@jfbu
Copy link
Contributor Author

jfbu commented Jul 23, 2022

Thanks again @humitos for kicking in, I will keep your hint for future.

Fortunately my oversight is now fixed, and compilation at Read The Docs of PDF is fine!

https://readthedocs.org/projects/sphinx/builds/17517802/

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants