Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix findall usage in KeyboardTransform #10504

Merged
merged 6 commits into from Jun 2, 2022
Merged

Fix findall usage in KeyboardTransform #10504

merged 6 commits into from Jun 2, 2022

Conversation

AA-Turner
Copy link
Member

Fixes #10495.

The bug was introduced to to using .findall which is a generator -- as the transform adds new nodes which match the condition in NodeMatcher, these are erroneously iterated over.

Feature or Bugfix

  • Bugfix

A

cc: @cyring @aaime please could you test this patch to see if it solves your issues?

@AA-Turner AA-Turner changed the base branch from 5.x to 5.0.x May 31, 2022 23:37
@AA-Turner AA-Turner added this to the 5.0.1 milestone May 31, 2022
@AA-Turner AA-Turner mentioned this pull request May 31, 2022
Closed
tk0miya
tk0miya reviewed Jun 1, 2022
View reviewed changes
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your quick work. LGTM with nits.

sphinx/builders/html/transforms.py Outdated Show resolved Hide resolved
tests/test_transforms_post_transforms.py Outdated Show resolved Hide resolved
@tk0miya tk0miya added the markup label Jun 1, 2022
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Jun 1, 2022
@polyzen
upgpkg: python-sphinx 5.0.0-2: Apply sphinx-doc/sphinx#10504
403100e 
Requested in order to fix Linux docs builds.

git-svn-id: file:///srv/repos/svn-community/svn@1218374 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Jun 1, 2022
@polyzen
upgpkg: python-sphinx 5.0.0-2: Apply sphinx-doc/sphinx#10504
0d14580 
Requested in order to fix Linux docs builds.


git-svn-id: file:///srv/repos/svn-community/svn@1218374 9fca08f4-af9d-4005-b8df-a31f2cc04f65
tk0miya
tk0miya approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a different opinion with you about testing. But it must not be a blocker of the release. So I'm going to merge this and continue discussion in another PR.

@tk0miya tk0miya merged commit 8aacb33 into sphinx-doc:5.0.x Jun 2, 2022
tk0miya added a commit that referenced this pull request Jun 2, 2022
@tk0miya
Update CHANGES for PR #10504
2a50b2e
@AA-Turner AA-Turner deleted the fix-kbd-findall branch June 16, 2022 22:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tk0miya tk0miya tk0miya approved these changes

Assignees
No one assigned
Labels
markup type:bug
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

IndexError: list index out of range
2 participants
@AA-Turner @tk0miya