Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Sphinx's Stemmer #10467

Merged
merged 37 commits into from Jun 16, 2022
Merged

Simplify Sphinx's Stemmer #10467

merged 37 commits into from Jun 16, 2022

Conversation

AA-Turner
Copy link
Member

Deprecate sphinx.util.stemmer in favour of using snowballstemmer directly. snowballstemmer is an unconditional dependency that auto-detects the C extension module.

I also removed the sphinx.util.stemmer.porter implementation (although keeping sphinx.util.stemmer.PorterStemmer) -- GitHub code search shows no usages of the module outwith Sphinx itself. (https://cs.github.com/?scopeName=All+repos&scope=&q=%2F%28from%7Cimport%29+sphinx.*%28%5Cbporter.*%7C+import+porter%29%2F).

Feature or Bugfix

  • Refactoring

A

PorterStemmer, BaseStemmer, PyStemmer, StandardStemmer, and get_stemmer are deprecated
sphinx.util.stemmer.porter is removed
@AA-Turner AA-Turner merged commit 881f66c into sphinx-doc:5.x Jun 16, 2022
@AA-Turner AA-Turner deleted the stemmer branch June 16, 2022 18:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant