Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnote & citation display for Docutils 0.18 #10463

Merged
merged 1 commit into from May 29, 2022

Conversation

AA-Turner
Copy link
Member

Docutils 0.18 moved away from <dl> et al for footnotes and definition lists. This PR ensures that Sphinx 5 will have consistent formatting. Closes #10415

Preview (Docutils 0.17)
Preview (Docutils 0.18)

@tk0miya please could this go into 5.0.0? As @stsewd noted it is a (visual) regression from Sphinx 4.5.0.

Feature or Bugfix

  • Bugfix

A

@tk0miya tk0miya added this to the 5.0.0 milestone May 22, 2022
@AA-Turner AA-Turner self-assigned this May 23, 2022
@tk0miya tk0miya mentioned this pull request May 28, 2022
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tk0miya tk0miya merged commit 3d3e932 into sphinx-doc:5.0.x May 29, 2022
@AA-Turner AA-Turner deleted the fix-css-docutils-0-18 branch June 16, 2022 22:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants