Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape base_uri in extlinks #10263

Merged
merged 3 commits into from Mar 27, 2022
Merged

Conversation

nicoa
Copy link
Contributor

@nicoa nicoa commented Mar 13, 2022

Subject: escape base_uri before regex compiling in extlinks

Feature or Bugfix

  • Bugfix

Purpose

The goal is to to avoid regex issues with URIs containing special characters. We experienced a recent change in the handling of extlinks to break using some sort of external URIs, thus using this fix to avoid that - see the below linked issue for details.

Relates

Closes #10205 .

@nicoa nicoa mentioned this pull request Mar 23, 2022
@tk0miya tk0miya added this to the 4.5.0 milestone Mar 27, 2022
@tk0miya tk0miya merged commit 746df61 into sphinx-doc:4.x Mar 27, 2022
tk0miya added a commit that referenced this pull request Mar 27, 2022
@tk0miya
Copy link
Member

tk0miya commented Mar 27, 2022

Thank you for your contribution!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regex failing on check of hardcoded links
2 participants