Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Close #9993: std domain: Allow to refer an inline target via ref role" #10178

Merged
merged 1 commit into from Mar 27, 2022

Conversation

stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Feb 8, 2022

Feature or Bugfix

  • Bugfix

Closes #10177

Purpose

Detail

  • Revert this change, which inadvertently made reference-style links need to be globally unique rather than locally unique

Relates

…arget via ref role"

This reverts commit e3ee8b3. This is a
breaking change that should not have been introduced in a minor release
(or arguably at all, given the impact).

Signed-off-by: Stephen Finucane <stephen@that.guru>
Closes: sphinx-doc#10177
@stephenfin
Copy link
Contributor Author

#10194 is an alternative that makes this configurable (disabled by default) rather than removing it entirely.

@tk0miya
Copy link
Member

tk0miya commented Mar 27, 2022

I determined to merge this to avoid bringing incompatible changes to 4.x. And I'll reconsider to implement it again on 5.0 release.

@tk0miya tk0miya merged commit 4a496bf into sphinx-doc:4.x Mar 27, 2022
tk0miya added a commit that referenced this pull request Mar 27, 2022
@stephenfin stephenfin deleted the issue-10177 branch March 28, 2022 00:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

References are now unique across doctree, not doc
2 participants