From 5c39d0c0688d011a26b806f9bcc90d194ad292f0 Mon Sep 17 00:00:00 2001 From: Takeshi KOMIYA Date: Thu, 24 Dec 2020 23:42:30 +0900 Subject: [PATCH] Fix #8583: autodoc: Unnecessary object comparision via ``__eq__`` method It should be compared by `is` keyword instead. --- CHANGES | 1 + sphinx/ext/autodoc/__init__.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index 867ba82e925..2bc9c3a82ae 100644 --- a/CHANGES +++ b/CHANGES @@ -22,6 +22,7 @@ Bugs fixed * #8567: autodoc: Instance attributes are incorrectly added to Parent class * #8566: autodoc: The ``autodoc-process-docstring`` event is emitted to the alias classes unexpectedly +* #8583: autodoc: Unnecessary object comparision via ``__eq__`` method * #8565: linkcheck: Fix PriorityQueue crash when link tuples are not comparable diff --git a/sphinx/ext/autodoc/__init__.py b/sphinx/ext/autodoc/__init__.py index 7a91d7d45c1..85f9f6de255 100644 --- a/sphinx/ext/autodoc/__init__.py +++ b/sphinx/ext/autodoc/__init__.py @@ -1829,7 +1829,7 @@ def import_object(self, raiseerror: bool = False) -> bool: return False def should_suppress_value_header(self) -> bool: - return (self.object == UNINITIALIZED_ATTR or + return (self.object is UNINITIALIZED_ATTR or super().should_suppress_value_header()) def get_doc(self, encoding: str = None, ignore: int = None) -> List[List[str]]: