From c0cc75530660afb01cd30f6b7ac55bbea2a64b22 Mon Sep 17 00:00:00 2001 From: Takeshi KOMIYA Date: Fri, 20 Mar 2020 19:34:19 +0900 Subject: [PATCH] test: Add testcase for make_id() --- tests/test_util_nodes.py | 37 ++++++++++++++++++++++++++++--------- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/tests/test_util_nodes.py b/tests/test_util_nodes.py index 76ba51800f9..1833414b020 100644 --- a/tests/test_util_nodes.py +++ b/tests/test_util_nodes.py @@ -183,18 +183,37 @@ def test_clean_astext(): assert 'hello world' == clean_astext(node) -def test_make_id(app): +@pytest.mark.parametrize( + 'prefix, term, expected', + [ + ('', '', 'id0'), + ('term', '', 'term-0'), + ('term', 'Sphinx', 'term-sphinx'), + ('', 'io.StringIO', 'io-stringio'), # contains a dot + ('', 'sphinx.setup_command', 'sphinx-setup-command'), # contains a dot + ('', '_io.StringIO', 'io-stringio'), # starts with underscore + ('', 'ｓｐｈｉｎｘ', 'sphinx'), # alphabets in unicode fullwidth characters + ('', '悠好', 'id0'), # multibytes text (in Chinese) + ('', 'Hello=悠好=こんにちは', 'hello'), # alphabets and multibytes text + ('', 'fünf', 'funf'), # latin1 (umlaut) + ('', '0sphinx', 'sphinx'), # starts with number + ('', 'sphinx-', 'sphinx'), # ends with hyphen + ]) +def test_make_id(app, prefix, term, expected): + document = create_new_document() + assert make_id(app.env, document, prefix, term) == expected + + +def test_make_id_already_registered(app): document = create_new_document() - assert make_id(app.env, document) == 'id0' - assert make_id(app.env, document, 'term') == 'term-0' - assert make_id(app.env, document, 'term', 'Sphinx') == 'term-sphinx' + document.ids['term-sphinx'] = True # register "term-sphinx" manually + assert make_id(app.env, document, 'term', 'Sphinx') == 'term-0' - # when same ID is already registered - document.ids['term-sphinx'] = True - assert make_id(app.env, document, 'term', 'Sphinx') == 'term-1' - document.ids['term-2'] = True - assert make_id(app.env, document, 'term') == 'term-3' +def test_make_id_sequential(app): + document = create_new_document() + document.ids['term-0'] = True + assert make_id(app.env, document, 'term') == 'term-1' @pytest.mark.parametrize(