Fix possible segmentation fault in get_magnetic_dataset
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we cannot assume magnetic symmetry search is always successful, this commit fixes gracefully to return NULL for such a difficult situation with possibly too high symprec and mag_symprec.
Codecov ReportBase: 85.12% // Head: 85.12% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #196 +/- ##
========================================
Coverage 85.12% 85.12%
========================================
Files 16 16
Lines 1318 1318
========================================
Hits 1122 1122
Misses 196 196 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we cannot assume magnetic symmetry search is always successful, this commit fixes gracefully to return NULL for such a difficult situation with possibly too high symprec and mag_symprec.