Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gorilla dependency #899

Merged
merged 2 commits into from Apr 21, 2020
Merged

Update gorilla dependency #899

merged 2 commits into from Apr 21, 2020

Conversation

jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Apr 21, 2020

This dependency bump is in reference to #898 and spf13/cobra#1091

Bumps to the latest patch version of gorilla/websocket 1.4

Let me know if there are questions!

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

sagikazarmark
sagikazarmark approved these changes Apr 21, 2020
View reviewed changes
Copy link
Collaborator

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'm not convinced that this is necessary to update in Viper (MVS and semantic import versioning gives full control to applications), especially since it's just an indirect dependency.

But it's probably for the best, so thanks!

@sagikazarmark sagikazarmark merged commit c42a305 into spf13:master Apr 21, 2020
@sagikazarmark sagikazarmark mentioned this pull request Apr 21, 2020
Closed
@jpmcb jpmcb deleted the update-deps branch April 21, 2020 15:21
@DarthHater
Copy link

@sagikazarmark it's just good to know someone cares :)

Thanks for doing this!

brainexe pushed a commit to brainexe/viper that referenced this pull request Nov 12, 2020
@jpmcb @brainexe
Update gorilla dependency (spf13#899)
4e7f1e2 
* Update gorilla dependency

* Run go mod tidy
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark sagikazarmark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpmcb @CLAassistant @DarthHater @sagikazarmark