Fix environment variable expansion in absPathify #495
Conversation
- Don't expand user home directory for variable names that simply have a HOME prefix; - Support expansion of variables not followed by the path separator.
|
@sagikazarmark Please review this PR when you have a moment, it fixes a real issue with variable expansion (see my |
There was a problem hiding this comment.
@qjcg thanks for the ping and the detailed explanation on the linked issue. I had a comment on the PR, but it generally looks good. It needs a rebase though, since it's quite old.
Dunno if @biochimia is up for it, so feel free to resubmit it if you want to speed things up.
| @@ -91,13 +91,23 @@ func insensitiviseMap(m map[string]interface{}) { | |||
| func absPathify(inPath string) string { | |||
| jww.INFO.Println("Trying to resolve absolute path to", inPath) | |||
|
|
|||
| if strings.HasPrefix(inPath, "$HOME") { | |||
| if strings.HasPrefix(inPath, "$HOME") && | |||
There was a problem hiding this comment.
Could this be rewritten as something like inPath == "$HOME" || strings.HasPrefix(inPath, "$HOME"+os.PathSeparator) or equivalent (or even using some sort of splitting)? The current condition is not really expressive.
Side note: looking at the path/filepath package there isn't much that can help here, but ideally it would be nice.
HOME prefix;