Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestPrintDefaults with go >= 1.18 #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix TestPrintDefaults with go >= 1.18 #369

wants to merge 1 commit into from

Conversation

pterjan
Copy link

@pterjan pterjan commented Dec 21, 2022

It no longer accepts Println with a constant ending with a newline:

Fixes #368

./flag_test.go:1242:3: fmt.Println arg list ends with redundant newline
FAIL github.com/spf13/pflag [build failed]

Also changing the previous line ven if it si not constant for consistency.

@pterjan
Fix TestPrintDefaults with go >= 1.18
ebb7e38 
It no longer accepts Println with a constant ending with a newline:

 Fixes spf13#368

./flag_test.go:1242:3: fmt.Println arg list ends with redundant newline
FAIL    github.com/spf13/pflag [build failed]

Also changing the previous line ven if it si not constant for
consistency.
@CLAassistant
Copy link

CLAassistant commented Dec 21, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"./flag_test.go:1242:3: fmt.Println arg list ends with redundant newline" with go >= 1.18
2 participants
@pterjan @CLAassistant