Handle single string=>string flags without quotes #179
+24
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamalsaha
commented
Aug 16, 2018
•
tamalsaha
commented
|
@eparis , this pr adds support for cc: @sgraham785 |
tamalsaha
changed the title
|
@eparis , if you can take a look at this, that will be great. |
eparis
reviewed
Aug 20, 2018
| @@ -140,13 +140,14 @@ func TestS2SCalledTwice(t *testing.T) { | |||
| var s2s map[string]string | |||
| f := setUpS2SFlagSet(&s2s) | |||
|
|
|||
| in := []string{"a=1,b=2", "b=3", `"e=5,6"`, `f="7,8"`} | |||
There was a problem hiding this comment.
Can you add a check that len(s2s) == len(expected) so we can't make this mistake again?
OK: --f1 "a=5,6" --f2 b=3,4 --f3 "c=5,6",d=7 Not OK: --f4 c="5,6"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.