bytes: add support for base64 encoded flags #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eparis
reviewed
Aug 8, 2018
bytes.go
Outdated
| // BytesBase64 adapts []byte for use as a flag. Value of flag is Base64 encoded | ||
| type bytesBase64Value []byte | ||
|
|
||
| func (bytesBase64 bytesBase64Value) String() string { |
There was a problem hiding this comment.
Can I get godoc style comments on everything exported? Then I'll merge.
Signed-off-by: Gorka Lerchundi Osa <glertxundi@gmail.com>
glerchundi
force-pushed
the
feature/support-base64
branch
from
aaf26eb
to
8061a58
Compare
|
@eparis PTAL. I added only a comment referencing which interface is implementing, Is that OK for you? |
|
Thanks @eparis!
…On Wed, 8 Aug 2018 at 17:28, Eric Paris ***@***.***> wrote:
Merged #177 <#177> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#177 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ACIPlhBWnT7M3XCu0vs5QMXjjKYQ5eO6ks5uOwOagaJpZM4Vzdxo>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gorka Lerchundi Osa glertxundi@gmail.com