Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update md2man to v2.0.0 #977

Merged
merged 1 commit into from Oct 19, 2019
Merged

Update md2man to v2.0.0 #977

merged 1 commit into from Oct 19, 2019

Conversation

pdf
Copy link
Contributor

@pdf pdf commented Oct 8, 2019

Pull in the v2 version of md2man, which carries the go.mod compatible version of blackfriday, avoiding broken dependencies for consumers.

Fixes #805

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@umarcor
Copy link
Contributor

umarcor commented Oct 8, 2019

This PR seems to not only pull v2 of md2man. Ref #953.

@pdf pdf changed the title Update dependencies Update md2man to v2.0.0 Oct 8, 2019
@pdf
Copy link
Contributor Author

pdf commented Oct 8, 2019

Apologies @umarcor - updated the PR to narrow scope of dependency updates.

@umarcor
Copy link
Contributor

umarcor commented Oct 9, 2019

No need to apologise at all! Actually, I'm good with you updating not only md2man, but also any other dependency that is worth it. See #954.

Therefore, when I referenced #953 above, I meant it would have been ok if you just added close #953 to your first message. Anyway, the description should match the changes. That's why I pointed it out.

@pdf
Copy link
Contributor Author

pdf commented Oct 9, 2019

I think it's probably fine to review dep changes independently if there's any chance of breakage - this one is particularly important as a standalone change, as currently performing a go get -u on any (mod-enabled) project that imports cobra results in broken dependencies for the importer.

@jharshman
Copy link
Collaborator

@pdf please fix conflicts.

@jharshman jharshman self-assigned this Oct 14, 2019
@pdf
Copy link
Contributor Author

pdf commented Oct 14, 2019

Rebased against master

@jharshman jharshman added this to the 1.0.0 milestone Oct 14, 2019
@jharshman jharshman merged commit 77e4d5a into spf13:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharshman jharshman jharshman approved these changes

@umarcor umarcor umarcor approved these changes

Assignees

@jharshman jharshman

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Issue generating markdown pages for commands when using vgo
4 participants
@pdf @CLAassistant @umarcor @jharshman