added variable to allow configuration of mousetrap message duration #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new variable MousetrapDisplayDuration allows to modify the default display duration of 5s, or to completely disable the timeout and wait for the user to press the return key.
|
|
|
@jharshman reviewed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New variable
MousetrapDisplayDurationallows to modify the default display duration of 5s, or to completely disable the timeout and wait for the user to press the return key.This allows for greater flexibility, instead of having to define a custom
preExecHookfor even such a small change. The requirement arose as in a UAT few users weren't able to read the message within the small default time span of only 5s. IMHO, if you wanted to keep the Mousetrap feature included, it should be configurable at least at a bare minimum.This PR does not change the default behaviour.