New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two word flags #807

Merged

eparis merged 1 commit into spf13:master from dtaniwaki:fix-for-double-dash-two-word-flags

Mar 11, 2019

Contributor

dtaniwaki commented Jan 12, 2019 •

edited

Flags like --namespace can also be a two-word flag, but the current completion considers only shorthand flags as two-word flags.

I also added test cases for two-word flags.


          Fix two word flags

b058852

dtaniwaki mentioned this pull request

Avoid conflicts with other cobra auto completions kubernetes/kubernetes#70470

Merged

Contributor Author

dtaniwaki commented Mar 11, 2019

@spf13 Could you review this PR?

eparis merged commit ba1052d into spf13:master

dtaniwaki deleted the fix-for-double-dash-two-word-flags branch

March 11, 2019 17:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment