Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add CloudQuery for projects using Cobra #1742

Merged
merged 2 commits into from Jun 25, 2022

Conversation

yevgenypats
Copy link
Contributor

Hi 馃憢

We are using Cobra so thought to add our project here for people's reference. We used to learn a lot from the examples here so thought to share back.

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines label Jun 23, 2022
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yevgenypats! Great to see more cool projects using Cobra 馃悕

You will need to sign the CLA before we can accept this contribution. Please see : #1742 (comment)

@@ -4,6 +4,7 @@
- [Bleve](https://blevesearch.com/)
- [CockroachDB](https://www.cockroachlabs.com/)
- [Cosmos SDK](https://github.com/cosmos/cosmos-sdk)
- [CloudQuery](https://github.com/cloudquery/cloudquery)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this up so it could be in alphabetical order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@yevgenypats
Copy link
Contributor Author

Not sure Im able to sign it with this link - https://cla-assistant.io/spf13/cobra?pullRequest=1742 maybe something is off there? or should I try again a bit later?

@yevgenypats
Copy link
Contributor Author

Not sure Im able to sign it with this link - https://cla-assistant.io/spf13/cobra?pullRequest=1742 maybe something is off there? or should I try again a bit later?

Ok seems like the CLA was down :) signed now.

@marckhouzam marckhouzam merged commit bba9331 into spf13:master Jun 25, 2022
@yevgenypats yevgenypats deleted the patch-1 branch June 25, 2022 17:13
@umarcor
Copy link
Contributor

umarcor commented Jun 27, 2022

@marckhouzam please milestone this PR.

@marckhouzam marckhouzam added this to the 1.6.0 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants