Provide option to hide default 'completion' cmd #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spf13#1507 Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
This was referenced Nov 24, 2021
Closed
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 24, 2021
Fixes spf13#1507 Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 25, 2021
Fixes spf13#1507 Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 25, 2021
Fixes spf13#1507 Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Dec 7, 2021
Fixes spf13#1507 Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
jpmcb
approved these changes
Dec 7, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1507 as requested by @jpmcb
This very simple change adds a user option to allow hiding the default completion command.
So, to tell Cobra to make the default
completioncommand hidden:It replace #1523 which was more flexible but much more complicated.